Fleet UI: Persist toast messages after a modal closes#17674
Merged
RachelElysia merged 2 commits intomainfrom Mar 18, 2024
Merged
Fleet UI: Persist toast messages after a modal closes#17674RachelElysia merged 2 commits intomainfrom
RachelElysia merged 2 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17674 +/- ##
==========================================
- Coverage 65.68% 65.68% -0.01%
==========================================
Files 1193 1193
Lines 108028 108026 -2
Branches 2574 2574
==========================================
- Hits 70961 70959 -2
Misses 31701 31701
Partials 5366 5366
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacobshandling
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Cerra #17624
Description
Note: I don't know why this recently broke, maybe the update to React, but the hide flash shouldn't have been in the onExit a modal call anywho.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/ororbit/changes/.